Angular: Fix some Ivy rendering glitches #15279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportCI ran the following commands for commit 27579f8. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
kroeder
reviewed
Jun 17, 2021
kroeder
approved these changes
Jun 17, 2021
shilman
changed the title
|
A bit late to the party, but I can confirm that the errors are gone in my repro. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: @yngvebn https://discord.com/channels/486522875931656193/490770949910691862/854687468321767444
What I did
fix(angular): call AbstractRenderer.resetCompiledComponents after full render
to avoid having
ngIf/ngForivy errorsfix(angular): destroy component when doc re render
to correctly destroy the components after an HMR
How to test
If your answer is yes to any of these, please make sure to include it in your PR.