-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: Point the update-notice to the changelog in the suggested version #19911
Conversation
@kylegach could you check if this is implemented correctly? will this work? is this a good idea? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So sorry for letting this sit so long! 🤦♂️
Thanks for catching this detail! The change is great conceptually, but needs an update in how it's executed, which I explained in my other comment.
Co-authored-by: Kyle Gach <kyle.gach@gmail.com>
@kylegach could to give this a review, and merge this PR of all is 👍 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this thoughtful fix, Carlos!
Issue:
The upgrade notice when starting Storybook always points to the CHANGELOG in the
next
branch. However, if e.g. you're in the 6.x releases, thenext
branch doesn't actually have the changelog for the next 6.x release. An easy way to fix this is to always point to the CHANGELOG residing in the tag corresponding to the suggested version.What I did
Changed
next
as a ref in the changelog URL to the ref of the suggested versionHow to test
If your answer is yes to any of these, please make sure to include it in your PR.