-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: split lib/addons
into manager & preview part, move code to manager-api
#19952
Conversation
lib/addons
into manager & preview part, move code to manager-api
…t's own addons store
confusing because it's a story of the manager, inside a folder for manager code..
@JReinhold I think I'd like to verify with you something that seems to be happening here: When I load this story locally, the play function is ran, and the component renders as the before did in chromatic: But it seems in chromatic the 'undefined' state is stuck, which would mean the play function did not run? but somehow the play-function DID run on other stories, or we'd see many more stories get flagged for review. |
I'll see if i can add a delay to the story, perhaps chromatic doesn't understand that this is actually a story with a play function at all, therefore it doesn't wait for the play function to finish. |
The special case about that story is that in itself it doesn't contain any interaction tests, but it contains a So Chromatic doesn't know there's an interaction test to run here. We should just add a delay that ensure the nested interaction test finishes. |
@@ -1,4 +1,4 @@ | |||
import { addons } from '@storybook/addons'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add an entry to migration.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Make sure to remember about documentation bits!
Move preview related code from
lib/addons
partially intopreview-api
before:
after:
I've also moved all manager related code from
lib/addons
to manager-api:lib/addons
still exist, but it just re-exports parts frompreview-api
andmanager-api
.This is for backwards compatibility