Build: Add missing dependencies to manager, unify TS to ~4.9.3 #20021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanVS
force-pushed
the
fix-export-gen
branch
from
d90f1a5
to
0a1105b
Compare
IanVS
force-pushed
the
fix-export-gen
branch
from
0a1105b
to
0cb44a3
Compare
IanVS
changed the title
ndelangen
approved these changes
Dec 5, 2022
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Possible alternative to #20018
What I did
The error mentioned in #20018 seems to indicate that
generate-exports-file.tsmight be running too early, before the packages that it is processing have been compiled. By adding the missing dependencies fromui/manager/src/globals/types.tsinto the package.json, they should be compiled by NX before manager is, hopefully solving the race condition.This also brings all of the packages in the monorepo up to typescript
~4.9.3, since a few were still at 4.6.3, and seemingly were causing build errors whensatisfieswas encountered.How to test
This is tricky, since the error only occurs occasionally. One approach might be to re-run the unit tests in github CI multiple times, to see if the intermittent error still occurs.