Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSF: Autotitle fix multiple dots and handle stories.js #21840

Merged
merged 11 commits into from
Nov 28, 2023
Merged

CSF: Autotitle fix multiple dots and handle stories.js #21840

merged 11 commits into from
Nov 28, 2023

Commits on Sep 20, 2023

  1. fix: handle button.group.stories.js in auto-title 

    The stripExtension() function aggressively removed everything after the
first dot in the filename. It should remove only (for example) .js or
.stories.js or .story.js

See the new test in autoTitle.test.ts for example.

Additionally the stripExtension() function was pulling double-duty by
cleaning up an empty leading string, a leftover from calling
pathJoin([titlePrefix, suffix]) with empty titlePrefix. Handle this
properly in the earlier code instead of hacking stripExtension().
    @agriffis
    agriffis committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    42a35ae View commit details
    Browse the repository at this point in the history

  2. feat: handle stories.js as meaningless for auto-titling

    @agriffis
    agriffis committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    8ce45d5 View commit details
    Browse the repository at this point in the history

  3. fix: don't remove redundant filename part if there won't be anything … 

    …left
    @agriffis
    agriffis committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    59fc329 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Merge branch 'release-8-0' into fix/auto-title-dotted-component

    @shilman
    shilman authored Nov 1, 2023
    Configuration menu
    Copy the full SHA
    66d1db8 View commit details
    Browse the repository at this point in the history

  2. Add 8.0 autotitle migration docs

    @shilman
    shilman committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    fcecff3 View commit details
    Browse the repository at this point in the history

  3. Improved migration

    @shilman
    shilman committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    cafe331 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Fix corner case Story.stories.js

    @shilman
    shilman committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    e15dd64 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. Merge branch 'release-8-0' into pr/agriffis/21840

    @ndelangen
    ndelangen committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    68eca71 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'release-8-0' into pr/agriffis/21840

    @ndelangen
    ndelangen committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    07ce1ea View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. Merge branch 'next' into fix/auto-title-dotted-component

    @ndelangen
    ndelangen authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    901a34c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'next' into fix/auto-title-dotted-component

    @shilman
    shilman authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    e7b3993 View commit details
    Browse the repository at this point in the history