-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: Run storybook dev
as part of storybook init
#22928
Conversation
01c0b8d
to
4cfd5da
Compare
05f448d
to
ac9fc72
Compare
storybook dev
as part of storybook init
storybook dev
as part of storybook init
code/lib/cli/src/initiate.ts
Outdated
process.env.CI !== 'true' && | ||
process.env.IN_STORYBOOK_SANDBOX !== 'true'; | ||
if (shouldRunDev) { | ||
logger.log('\nRunning Storybook'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running Storybook automatically. To run it manually, use the following command: xyz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add it in a box
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shilman @jonniebigodes here's how it looks like after the change:
For Angular Webpack (the most verbose we have):
Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I'm sure we can clean all this up if we rework the CLI, but for now I'd say ship it!
Closes #22871
What I did
How to test
./code/lib/cli/bin/index.js init --initial-path=/settings/shortcuts
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]