Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue3: Fix pnp by making compiler-core a dependency #25311

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

shilman
Copy link
Member

@shilman shilman commented Dec 23, 2023

Closes #23817

What I did

  • Make vue3/compiler-core a regular dependency

As a peer dependency it means that the user has to install that dependency into their project. To fix this, we can either (1) install it for them in their package.json or (2) make it a regular dependency. This PR opts for the latter solution.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

In a fresh Vite Vue3 project, install Storybook with Yarn pnp:

corepack enable
yarn set version stable
yarn dlx storybook@next init

The project will fail to start. Setting the version to this canary in package.json and reinstalling should fix it.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-25311-sha-2ae4efa4. Install it by pinning all your Storybook dependencies to that version.

More information
Published version 0.0.0-pr-25311-sha-2ae4efa4
Triggered by @shilman
Repository storybookjs/storybook
Branch shilman/vue3-fix-compiler
Commit 2ae4efa4
Datetime Sat Dec 23 12:13:29 UTC 2023 (1703333609)
Workflow run 7308137124

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=25311

@shilman shilman added bug patch:yes Bugfix & documentation PR that need to be picked to main branch vue3 labels Dec 23, 2023
@shilman
Copy link
Member Author

shilman commented Dec 29, 2023

Self-merging @kasperpeulen

@shilman shilman merged commit b835806 into next Dec 29, 2023
65 of 66 checks passed
@shilman shilman deleted the shilman/vue3-fix-compiler branch December 29, 2023 11:27
shilman added a commit that referenced this pull request Dec 30, 2023
Vue3: Fix pnp by making compiler-core a dependency
(cherry picked from commit b835806)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch vue3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Storybook for Vue tutorial Error
1 participant