Vue3: Fix pnp by making compiler-core a dependency #25311
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23817
What I did
vue3/compiler-core
a regular dependencyAs a peer dependency it means that the user has to install that dependency into their project. To fix this, we can either (1) install it for them in their
package.json
or (2) make it a regular dependency. This PR opts for the latter solution.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
In a fresh Vite Vue3 project, install Storybook with Yarn pnp:
The project will fail to start. Setting the version to this canary in package.json and reinstalling should fix it.
🦋 Canary release
This pull request has been released as version
0.0.0-pr-25311-sha-2ae4efa4
. Install it by pinning all your Storybook dependencies to that version.More information
0.0.0-pr-25311-sha-2ae4efa4
shilman/vue3-fix-compiler
2ae4efa4
1703333609
)To request a new release of this pull request, mention the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=25311