Addon-docs: Fix MDX components not applied in Vite and theme loading twice #25925
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25761
Fixes #25737
Fixes #24046
What I did
When a user has something else than the latest React installed, the dependencies of addon-docs will get duplicated in
@storybook/addon-docs/node_modules
- that's apparently just how package managers work. Therefore in that case we need to ensure that some of the dependencies are deduplicated in Vite (Webpack already does this):@storybook/theming
and other related packages@mdx-js/react
similar toreact
andreact-dom
, like we already did for Webpack. That's because multiple instances of that package would get bundled resulting in theMDXProvider
being different, and thus none of the default components being available.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-25925-sha-38205a1c
. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-25925-sha-38205a1c sandbox
or in an existing project withnpx storybook@0.0.0-pr-25925-sha-38205a1c upgrade
.More information
0.0.0-pr-25925-sha-38205a1c
jeppe/deduplicate-addon-docs-packages
38205a1c
1707224324
)To request a new release of this pull request, mention the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=25925