Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for memoized components #6347

Merged
merged 3 commits into from
Apr 11, 2019
Merged

Conversation

rafaelfbs
Copy link
Contributor

Issue: #6298

What I did

Fix component code and component prop table to display info of memoized components. React encapsulates a memoized component as an object with property "type".

How to test

  • Is this testable with Jest or Chromatic screenshots? Yes, I added a jest test scenario.
  • Does this need a new example in the kitchen sink apps? No.
  • Does this need an update to the documentation? No.

@shilman
Copy link
Member

shilman commented Mar 30, 2019

Awesome @rafaelfbs 💯

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great 👍

@ndelangen ndelangen self-assigned this Apr 11, 2019
@codecov
Copy link

codecov bot commented Apr 11, 2019

Codecov Report

Merging #6347 into next will decrease coverage by 2.46%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             next   #6347      +/-   ##
=========================================
- Coverage   40.77%   38.3%   -2.47%     
=========================================
  Files         615     650      +35     
  Lines        8511    9854    +1343     
  Branches      535     388     -147     
=========================================
+ Hits         3470    3775     +305     
- Misses       4949    6019    +1070     
+ Partials       92      60      -32
Impacted Files Coverage Δ
addons/info/src/react-utils.js 100% <100%> (ø)
addons/info/src/components/Node.js 86.2% <100%> (-1.3%) ⬇️
addons/info/src/components/Story.js 88.23% <100%> (-0.12%) ⬇️
addons/info/src/components/Props.js 94.11% <100%> (ø) ⬆️
addons/actions/src/preview/action.ts 90.9% <0%> (-9.1%) ⬇️
lib/core/src/client/preview/start.js 72.94% <0%> (-0.93%) ⬇️
addons/knobs/src/components/Panel.js 80% <0%> (-0.27%) ⬇️
addons/ondevice-knobs/src/types/Date.js 0% <0%> (ø) ⬆️
app/polymer/src/client/index.js 0% <0%> (ø) ⬆️
app/html/standalone.js 0% <0%> (ø) ⬆️
... and 455 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50de13f...b327281. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 11, 2019

Codecov Report

Merging #6347 into next will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #6347      +/-   ##
==========================================
+ Coverage   40.77%   40.77%   +<.01%     
==========================================
  Files         615      616       +1     
  Lines        8511     8512       +1     
  Branches      535      535              
==========================================
+ Hits         3470     3471       +1     
  Misses       4949     4949              
  Partials       92       92
Impacted Files Coverage Δ
addons/info/src/react-utils.js 100% <100%> (ø)
addons/info/src/components/Node.js 86.2% <100%> (-1.3%) ⬇️
addons/info/src/components/Story.js 88.23% <100%> (-0.12%) ⬇️
addons/info/src/components/Props.js 94.11% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50de13f...7563eff. Read the comment docs.

@vercel
Copy link

vercel bot commented Apr 11, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fork-rafaelfbs-next.storybook.now.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants