generated from storybookjs/addon-kit
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support auto title stories #35
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbf
commented
Jan 28, 2022
shilman
approved these changes
Jan 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 looking great @yannbf
Except failing tests 🙈 😅 |
That's on purpose, I wanted to discuss with you if the approach was the final one, then I'd write the test |
yannbf
force-pushed
the
feat/CH-1358-support-auto-title
branch
from
January 31, 2022 16:35
c518ba7
to
8a26a58
Compare
This was referenced Feb 3, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #19
📦 Published PR as canary version:
0.0.2-canary.35.8a26a58.0
✨ Test out this PR locally via:
npm install @storybook/test-runner@0.0.2-canary.35.8a26a58.0 # or yarn add @storybook/test-runner@0.0.2-canary.35.8a26a58.0
Version
Published prerelease version:
v0.0.2-next.4
Changelog
🐛 Bug Fix
next
📝 Documentation
Authors: 2