Add Python 3 support

[meejah]

Are there plans for this library to support Python3?

[str4d]

Yes, we should add Python 3 support. My vague recollection is that this didn't originally support Python 3 because Twisted itself didn't at the time. I assume this has since been fixed 😄

[meejah]

Although Twisted doesn't say "Python 3 Support(tm)" yet (because not everything is ported?) nearly all of it is (and way more than enough for e.g. txtorcon). You can even use async-def and await if you like :)

[evilaliv3]

While implementing Python3, I would suggest inside @txi2p to keep the codebase still backward compatible with Python2 as done in @txtorcon.

@str4d, is there any particular need for basing the codebase still on tx 10?

Here we are discussing a possible adoption on @globaleaks as optional/diversity protocol with respect to Tor and what we would need is support for python3 for packaging it for Ubuntu Bionic (py3, twisted 17.9.0) and Ubuntu Xenial (py2, twisted 16.0.0): #7

[str4d]

@str4d, is there any particular need for basing the codebase still on tx 10?

Nope, that was just the minimum version necessary to implement the functionality needed by txi2p at the time I wrote it (when older versions of Twisted were still prevalent). I have no personal need for this to support older Twisted versions.

[meejah]

Something (else) to consider is that you could switch to using https://github.com/crossbario/txaio which would give you asyncio and twisted support .. on the downside, this is like "lowest-common denominator between tx and aio" so you have to use call-back style (e.g. can't use @inlineCallbacks -- but a quick search seems to indicate you're not anyway).

[str4d]

Turns out I started porting txi2p to Python 3 in 2015, and then completely forgot about the branch 😅

I'm rebasing the branch now (it was based on 0.2, so is missing a bunch of changes), so I'll see how things look afterwards.