Skip to content

iterative event loop #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 24, 2025
Merged

iterative event loop #268

merged 2 commits into from
Jun 24, 2025

Conversation

pgrayy
Copy link
Member

@pgrayy pgrayy commented Jun 23, 2025

Description

We are currently working on support for an iterative async stream method on the agent class (#83). As part of this work, we need to yield underlying events of the event loop. This PR thus converts the event_loop_cycle function to a generator.

Related Issues

#83

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

  • I ran hatch run prepare

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

pgrayy
pgrayy commented Jun 23, 2025
View reviewed changes
@pgrayy pgrayy requested review from zastrowm and Unshure June 23, 2025 15:34
zastrowm
zastrowm previously approved these changes Jun 23, 2025
View reviewed changes
@pgrayy pgrayy closed this Jun 23, 2025
@pgrayy pgrayy reopened this Jun 23, 2025
@pgrayy pgrayy marked this pull request as draft June 23, 2025 17:16
Unshure
Unshure reviewed Jun 23, 2025
View reviewed changes
@pgrayy pgrayy force-pushed the async-event-loop branch from 8ea17c1 to 2d5e5de Compare June 23, 2025 18:53
@pgrayy pgrayy force-pushed the async-event-loop branch from 2d5e5de to 26f4497 Compare June 23, 2025 18:54
@pgrayy pgrayy force-pushed the async-event-loop branch from 26f4497 to 3f9ff02 Compare June 23, 2025 18:55
@pgrayy pgrayy force-pushed the async-event-loop branch from 3f9ff02 to 8183b1c Compare June 23, 2025 18:56
@pgrayy pgrayy force-pushed the async-event-loop branch from 8183b1c to 6061f58 Compare June 23, 2025 18:57
pgrayy
pgrayy commented Jun 23, 2025
View reviewed changes
@pgrayy pgrayy marked this pull request as ready for review June 23, 2025 20:21
@pgrayy pgrayy mentioned this pull request Jun 23, 2025
Closed
Unshure
Unshure reviewed Jun 24, 2025
View reviewed changes
pgrayy
pgrayy commented Jun 24, 2025
View reviewed changes
@pgrayy pgrayy merged commit 3ae8d77 into strands-agents:main Jun 24, 2025
12 checks passed
@pgrayy pgrayy deleted the async-event-loop branch June 27, 2025 13:16
jsamuel1 pushed a commit to jsamuel1/sdk-python that referenced this pull request Jul 9, 2025
@pgrayy @jsamuel1
iterative event loop (strands-agents#268)
09c03fa
dbschmigelski pushed a commit to Ketansuhaas/sdk-python that referenced this pull request Jul 24, 2025
@pgrayy @dbschmigelski
iterative event loop (strands-agents#268)
1950f49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zastrowm zastrowm zastrowm approved these changes

@Unshure Unshure Unshure approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pgrayy @zastrowm @Unshure