Don't re-run workflows on un/approvals #516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were necessary when we had conditional running but we switched to needing to approve all workflows for non-maintainers, so we no longer need these.
cagataycali
approved these changes
Jul 22, 2025
zastrowm
added a commit
to zastrowm/tools
that referenced
this pull request
Jul 22, 2025
These changes: - Provide a single command `hatch run prepare` to run all required commands - Streamline the GitHub PR template - Avoids running the github workflows un-necessarily These changes were originally made to the SDK a while ago: - Streamlining contributions: strands-agents/sdk-python/pull/221 - Not running workflows on un/approvals: strands-agents/sdk-python/pull/516
7 tasks
cagataycali
pushed a commit
to strands-agents/tools
that referenced
this pull request
Jul 22, 2025
These changes: - Provide a single command `hatch run prepare` to run all required commands - Streamline the GitHub PR template - Avoids running the github workflows un-necessarily These changes were originally made to the SDK a while ago: - Streamlining contributions: strands-agents/sdk-python/pull/221 - Not running workflows on un/approvals: strands-agents/sdk-python/pull/516 Co-authored-by: Mackenzie Zastrow <zastrowm@users.noreply.github.com>
dbschmigelski
pushed a commit
to Ketansuhaas/sdk-python
that referenced
this pull request
Jul 24, 2025
These were necessary when we had conditional running but we switched to needing to approve all workflows for non-maintainers, so we no longer need these. Co-authored-by: Mackenzie Zastrow <zastrowm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These were necessary when we had conditional running but we switched to needing to approve all workflows for non-maintainers, so we no longer need these.
Type of Change
Bug fix
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.