-
Notifications
You must be signed in to change notification settings - Fork 377
feat: decouple Strands ContentBlock and BedrockModel #836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dbschmigelski
merged 6 commits into
strands-agents:main
from
dbschmigelski:message-requirements
Sep 18, 2025
Merged
feat: decouple Strands ContentBlock and BedrockModel #836
dbschmigelski
merged 6 commits into
strands-agents:main
from
dbschmigelski:message-requirements
Sep 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unshure
requested changes
Sep 11, 2025
baae693
to
83b6157
Compare
dbschmigelski
commented
Sep 15, 2025
7 tasks
zastrowm
approved these changes
Sep 17, 2025
7 tasks
Unshure
approved these changes
Sep 18, 2025
Created a new issue to add support for generic content blocks for better extensibility: #889 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a problem with AWS Bedrock's strict API validation. Bedrock throws validation exceptions when it receives unexpected fields in content blocks, unlike other model providers that ignore unknown fields. This means we need to filter all content blocks before sending them to Bedrock.
The current implementation only handles tool result blocks with hardcoded filtering. But Bedrock supports many content block types (image, document, video, reasoning, citations, cache points, guard content, etc.), each with different field requirements. The hardcoded approach doesn't scale as we add support for more content types.
This Refactor decouples the Strands ContentType and the Bedrock Model
The original implementation only handled filtering at the top level. After a comment I began investigating filtering deeply nested objects. Where this broke down was the inability to model recursive structures using the key filtering technique.
So what is introduced here is effectively the same strategy we use across all other providers. We provide a content mapping from the Strands ContentTypes to the model provider. No longer is Bedrock special cased. This will allow us to grow the content types as we wish independent of the underlying bedrock impl. We still can, and should, use the Bedrock shapes as our inspiration for new features but we are no longer as tightly coupled.
For a different approach that I may want to consider in the future, I believe it may be useful to simply create
_Bedrock{}ContentType
shapes in Pydantic. Then in a single call we just do_BedrockContent.model_validate(input)
where Pydantic will handle this; the same strategy can be used across different providers and may clean up our code.Related Issues
#341
#343
Documentation PR
N/A
Type of Change
Chore to allow future change
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepare
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.