generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 424
feat(models): use tool for litellm structured_output when supports_response_schema=false #957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dbschmigelski
merged 4 commits into
strands-agents:main
from
dbschmigelski:litellm/structured_output_callback
Oct 9, 2025
Merged
feat(models): use tool for litellm structured_output when supports_response_schema=false #957
dbschmigelski
merged 4 commits into
strands-agents:main
from
dbschmigelski:litellm/structured_output_callback
Oct 9, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbschmigelski
commented
Oct 1, 2025
pgrayy
reviewed
Oct 7, 2025
Unshure
reviewed
Oct 7, 2025
3 tasks
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
pgrayy
approved these changes
Oct 9, 2025
JackYPCOnline
approved these changes
Oct 9, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In LiteLLMModel we currently attempt to perform structured_output using the model's native capabilities. This is checked using the
supports_response_schema
method.This has two edge cases which are causing customer failures.
The first obvious one is that if a model does not support structured output we are failing hard. This means that if a customer changes the model id, code that previously worked will now fail with
ValueError("Model does not support response_format")
.The second is what appears to be a bug in LiteLLM.
supports_response_schema
does not appear to work with proxies. Looking at their code, they are not passing along proxy information, meaning there is no ability to perform a runtime check for proxies.To fix this, when
supports_response_schema
returns false, we now fallback to the similar tool approach used in other model providers. A fix in LiteLLM will be explored but in the immediate term we need to unblock customers.Related Issues
#862
#909
Type of Change
New feature
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepare
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.