event loop - handle model execution #958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgrayy
commented
Oct 2, 2025
pgrayy
commented
Oct 2, 2025
pgrayy
commented
Oct 2, 2025
pgrayy
commented
Oct 2, 2025
pgrayy
commented
Oct 2, 2025
Unshure
approved these changes
Oct 2, 2025
JackYPCOnline
approved these changes
Oct 2, 2025
JackYPCOnline
added a commit
that referenced
this pull request
Oct 10, 2025
* feat: replace kwargs with invocation_state in agent APIs * fix: handle **kwargs in stream_async. * feat: add a unit test for the change * Update src/strands/agent/agent.py Co-authored-by: Nick Clegg <nac542@gmail.com> * tool - executors - concurrent - remove no-op gather (#954) * feat(telemetry): updated traces to match OTEL v1.37 semantic conventions (#952) * event loop - handle model execution (#958) * feat: implement concurrent message reading for session managers (#897) Replace sequential message loading with async concurrent reading in both S3SessionManager and FileSessionManager to improve performance for long conversations. Uses asyncio.gather() with run_in_executor() to read multiple messages simultaneously while maintaining proper ordering. Resolves: #874 Co-authored-by: Vamil Gandhi <vamgan@amazon.com> * hooks - before tool call event - cancel tool (#964) * fix(telemetry): removed double serialization for events (#977) * fix(litellm): map LiteLLM context-window errors to ContextWindowOverflowException (#994) * feat: add more tests and adjust invocation_state dic structure * Apply suggestion from @Unshure Co-authored-by: Nick Clegg <nac542@gmail.com> * fix: adjust **kwargs in multiagent primitives --------- Co-authored-by: Nick Clegg <nac542@gmail.com> Co-authored-by: Patrick Gray <pgrayy@amazon.com> Co-authored-by: poshinchen <pschen@amazon.com> Co-authored-by: Vamil Gandhi <hello@vamilgandhi.com> Co-authored-by: Vamil Gandhi <vamgan@amazon.com> Co-authored-by: ratish <114130421+Ratish1@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moving the model execution logic in the agent loop into a function so that we can more easily condition around it when resuming after interrupt. For more details, please see comments under the files changed page.
To get a rough idea of what the end result will be for resuming, see here.
Related Issues
#204
Documentation PR
N/A
Type of Change
Other (please describe): Code reorg.
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepare: I am not changing any logic in this PR and so we can rely on the existing unit/integ tests.Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.