generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 425
feat: Refactor and update tool loading to support modules #989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+364
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c55409e
to
c50ecc7
Compare
c50ecc7
to
d20ce0d
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
pgrayy
reviewed
Oct 8, 2025
8c90e56
to
dda2e8c
Compare
pgrayy
previously approved these changes
Oct 8, 2025
dbschmigelski
previously approved these changes
Oct 8, 2025
Co-authored-by: Patrick Gray <pgrayy@amazon.com>
Co-authored-by: Patrick Gray <pgrayy@amazon.com>
pgrayy
approved these changes
Oct 8, 2025
dbschmigelski
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor the tool loading logic as it was difficult to follow. I also added (or repaired) the functionality to load tools form the environment based on the tool string.
This makes the following code possible:
I ended up deprecating a bunch of methods because they were so hard to understand what they were doing before. There was a lot of misdirection and poorly named function arguments.
Ive refactored it to what I think is easier to follow, while keeping the old methods for "backwards compatibility". Ive added deprecation methods to all of the things no longer in use so we can remove them in 2.0.
Related Issues
N/A
Documentation PR
N/A
Type of Change
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepare
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.