Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bringing new changes to melodic #244

Closed
wants to merge 26 commits into from
Closed

Bringing new changes to melodic #244

wants to merge 26 commits into from

Conversation

hawesie
Copy link
Member

@hawesie hawesie commented Apr 4, 2019

This is needed to bring the changes added in #238 #240 #241 #242 #243 into melodic

jorgenfb and others added 23 commits October 9, 2018 09:11
Make sure None / null values reaches the parameter server
It is subscribe rather than subsribe
display more info on replication
append _meta.published_at for stamped messages
shutdown publisher on destruction
add method to get num subscribers for insertion
Exposes a new service `/config_manager/reset_params std_srvs/Trigger`
that will reset all local overrides their default value. This provides
a ROS compatible way of getting back to the default values.
adds service to reset all local overrides.
The existing solution bind the mongod server to all interfaces. This
exposes the server to the outside. This could be a potensial security
issue if someone has access to your network. This change allows you
to only bind the server to the host specified by the
`mongodb_host` parameter. The solution was created with a flag
defaulting to false to prevent this from being a breaking change.

Specifying the argument `bind_to_host` will add a bind argument to the
executable:
```
[..., "--bind_ip", self._mongo_host]
```

Info: The `bind_ip` argument [supports hostnames, ipaddresses
and socket
paths](https://docs.mongodb.com/manual/reference/program/mongod/#cmdoption-mongod-bind-ip)
so using `localhost` or `127.0.0.1` is valid for binding to
localhost only. To bind to all interfaces use `0.0.0.0`.
@knorth55
Copy link
Contributor

knorth55 commented Sep 2, 2019

what is the status of this issue?
is anyone working on this PR?
if not, I can work on this PR.

@hawesie
Copy link
Member Author

hawesie commented Sep 2, 2019

I'm not working on it, so that probably means it's over to you!

@knorth55
Copy link
Contributor

knorth55 commented Sep 2, 2019

Good, thanks!
I will work on this.

Added package scons to installation
@knorth55
Copy link
Contributor

knorth55 commented Nov 8, 2019

Are you trying to merge kinetic-devel to melodic-devel?
If not, I made PR for merging #253.
We are really looking forward the release including new features in Melodic (jsk-ros-pkg/jsk_robot#1121)

@hawesie hawesie closed this Nov 11, 2019
@hawesie
Copy link
Member Author

hawesie commented Nov 11, 2019

Brilliant, thanks!

@knorth55
Copy link
Contributor

I merged the new features, which are added in kinetic-devel until 0.4.5, to melodic-devel.
I'm looking forward the new release 0.5.2 in melodic.

@hawesie
Copy link
Member Author

hawesie commented Nov 11, 2019

@knorth55 it's on the todo list...

@hawesie
Copy link
Member Author

hawesie commented Nov 11, 2019

ros/rosdistro#22954

@knorth55
Copy link
Contributor

Thank you so much! @hawesie
I'm sorry to rush you the release.

@hawesie
Copy link
Member Author

hawesie commented Nov 11, 2019

No worries, I actually always need the prompt to do the release since I sometimes forget that's a necessary step...

@bilal9876
Copy link

please i cannot install the right version of mongodb ( i use melodic and rosplan)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants