-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bringing new changes to melodic #244
Conversation
Make sure None / null values reaches the parameter server
It is subscribe rather than subsribe
Fix typo in log message
display more info on replication
append _meta.published_at for stamped messages
shutdown publisher on destruction
add method to get num subscribers for insertion
Exposes a new service `/config_manager/reset_params std_srvs/Trigger` that will reset all local overrides their default value. This provides a ROS compatible way of getting back to the default values.
adds service to reset all local overrides.
The existing solution bind the mongod server to all interfaces. This exposes the server to the outside. This could be a potensial security issue if someone has access to your network. This change allows you to only bind the server to the host specified by the `mongodb_host` parameter. The solution was created with a flag defaulting to false to prevent this from being a breaking change. Specifying the argument `bind_to_host` will add a bind argument to the executable: ``` [..., "--bind_ip", self._mongo_host] ``` Info: The `bind_ip` argument [supports hostnames, ipaddresses and socket paths](https://docs.mongodb.com/manual/reference/program/mongod/#cmdoption-mongod-bind-ip) so using `localhost` or `127.0.0.1` is valid for binding to localhost only. To bind to all interfaces use `0.0.0.0`.
Allow to bind mongod to host
what is the status of this issue? |
I'm not working on it, so that probably means it's over to you! |
Good, thanks! |
Added package scons to installation
Updated README
Are you trying to merge kinetic-devel to melodic-devel? |
Brilliant, thanks! |
I merged the new features, which are added in |
@knorth55 it's on the todo list... |
Thank you so much! @hawesie |
No worries, I actually always need the prompt to do the release since I sometimes forget that's a necessary step... |
please i cannot install the right version of mongodb ( i use melodic and rosplan) |
This is needed to bring the changes added in #238 #240 #241 #242 #243 into melodic