Skip to content

Improve custom controller examples #1956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Conversation

innerdvations
Copy link
Collaborator

What does it do?

Improves examples on writing custom controllers

Why is it needed?

Users were confused about the different methods that can be used

Related issue(s)/PR(s)

Let us know if this is related to any issue/pull request

@innerdvations innerdvations added the source: Dev Docs PRs/issues targeting the Developer Docs label Dec 18, 2023
@innerdvations innerdvations self-assigned this Dec 18, 2023
Copy link

vercel bot commented Dec 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2023 10:26am

Copy link
Collaborator

@pwizla pwizla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you so much, Ben, for helping us solve this long-running user issue 🥳

@pwizla pwizla added this to the 4.15.7 milestone Dec 18, 2023
@pwizla pwizla added pr: updated content PRs updating existing documentation content topic: backend customization Temporary label to group PRs for backend customization improvements labels Dec 19, 2023
@pwizla
Copy link
Collaborator

pwizla commented Dec 20, 2023

Thanks for the additional reviews!
FYI I will merge this PR this afternoon, as we'll "close the year" today for documentation and we have an announcement recap for community users, with everything we improved over the past semester around backend customization.

@pwizla pwizla merged commit 4f2eb5e into main Dec 20, 2023
@pwizla pwizla deleted the docs/improve-core-controller-examples branch December 20, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: updated content PRs updating existing documentation content source: Dev Docs PRs/issues targeting the Developer Docs topic: backend customization Temporary label to group PRs for backend customization improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants