-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Node 14 support, add Node 20 #16557
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't planning on updating all the engines just wanted to enable the tests but why not :P
Update: We decided to remove Node 14 from engines to avoid potential issues if we use functions that are not available in node 14. |
It appears Node 20 with mysql 5 in the CI (I can't reproduce locally) returns unsorted results from the API in a different order than other cases. I consider that a bug with the test and will fix it everywhere it occurs, but I want to confirm with @alexandrebodin that users should not expect results from the API to come in any specific order unless explicitly sorted in the query params. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
users should not expect results from the API to come in any specific order unless explicitly sorted in the query params
That should definitely be the expected behavior 💯
I would say we can go ahead with this, but we can also wait for @alexandrebodin approval if you prefer.
@innerdvations I can confirm about the sorting. Just very surprising that it occurs for node 20. A bit worrying. I'll let you double check this can't come from a known node 20 change and move forward with @Convly |
This pull request has been mentioned on Strapi Community Forum. There might be relevant details there: |
What does it do?
Removes support for node 14 and adds node 20.
Why is it needed?
Node 14 is EOL (including security fixes) and Node 20 has been released.
How to test it?
Everything should work when using Node 20 and Strapi should no longer start with Node 14
Related issue(s)/PR(s)
Blocking #16849
Documentation PR