-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix intermittently failing API tests by using consistent versions of sqlite packages #17490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
innerdvations
added
source: tooling
Source is GitHub tooling/tests/ect
pr: fix
This PR is fixing a bug
labels
Jul 28, 2023
Size Change: 0 B Total Size: 1.52 MB ℹ️ View Unchanged
|
innerdvations
changed the title
Fix API test that fails inconsistently in CI
Fix intermittantly failing API tests by using consistent versions of sqlite packages
Jul 31, 2023
innerdvations
changed the title
Fix intermittantly failing API tests by using consistent versions of sqlite packages
Fix intermittently failing API tests by using consistent versions of sqlite packages
Jul 31, 2023
Convly
approved these changes
Jul 31, 2023
Looks like this didn't actually work. Will look into it when I get a chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Upgrade and set a consistent version of both sqlite3 and better-sqlite3 in an attempt to stop the failing sqlite tests that sometimes fail on github CI
Note: we can't upgrade to sqlite3 v5.1.6 yet because it fully deprecates the timestamp format we are inserting in many tests and causes most of them to start failing. But this will at least ensure we're at least using the same versions everywhere to assist in reproducing the problem if this doesn't solve it.
Why is it needed?
Tests keep failing but there doesn't seem to be a consistent pattern. I actually suspect this does NOT solve the issue, because once (out of about 15 tries) I saw the same error on mysql. But this at least seems to make them pass every time I've tried so far.
How to test it?
CI tests should all pass consistently
Related issue(s)/PR(s)
Let us know if this is related to any issue/pull request