Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content-releases): add endpoint to update a release action #18946

Merged

Conversation

markkaylor
Copy link
Contributor

What does it do?

  • Add endpoint to update a release action

Why is it needed?

  • To change the type of an action already in a release

How to test it?

  • Make sure you have a release with some release actions
  • Make sure you have the id for the release and the action you want to delete
  • Make a PUT request to `/content-releases/:releaseId/actions/:actionId
{ type: 'publish' | 'unpublish'}
  • Confirm it was updated in the db
  • Try to send something that isn't publish or unpublish
  • Check a role that doesn't have permissions cannot make the request and that permissions can be given

@markkaylor markkaylor self-assigned this Nov 29, 2023
@markkaylor markkaylor changed the title chore(releases): setup releases plugin (#18401) feat(content-releases): add endpoint to update a release action Nov 29, 2023
@markkaylor
Copy link
Contributor Author

ℹ️ need to update where releaseId

@markkaylor markkaylor marked this pull request as draft November 30, 2023 08:32
@markkaylor markkaylor force-pushed the content-releases/update-release-action branch from 921fc4c to 4ff2390 Compare December 4, 2023 09:39
@markkaylor markkaylor marked this pull request as ready for review December 4, 2023 10:02
Copy link
Contributor

@Feranchz Feranchz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it's working great!

@markkaylor markkaylor merged commit 76f8b2f into feature/content-releases Dec 4, 2023
134 checks passed
@markkaylor markkaylor deleted the content-releases/update-release-action branch December 4, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants