Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed the minimum kubernetes version to 1.24 and corrected the top … #29

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

rvyas-strata
Copy link
Contributor

@rvyas-strata rvyas-strata commented Oct 13, 2023

Description This PR makes changes to the README.md

Testing Not Applicable

Documentation Refer to Description

rhysecampbell
rhysecampbell previously approved these changes Oct 20, 2023
Copy link

@rhysecampbell rhysecampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The additional language makes sense.

Signed-off-by: rvyas-strata <81174204+rvyas-strata@users.noreply.github.com>
Signed-off-by: rvyas-strata <81174204+rvyas-strata@users.noreply.github.com>
Copy link

@rhysecampbell rhysecampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 1.2.4 is not the latest, but we know it is stable.

charts/orchestrator/Chart.yaml Show resolved Hide resolved
@wfernandes
Copy link
Member

Also...rebase and sign the commits. git commit --signoff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants