Minimal changes to support off-device buffering #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? For help please reach out to support@opennetworking.org. The list of admins can be updated in the Jenkins configuration. |
robertmacdavid
commented
Sep 25, 2020
|
add to allowlist |
ccascone
reviewed
Sep 25, 2020
ccascone
reviewed
Sep 25, 2020
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
============================================
- Coverage 66.83% 66.56% -0.28%
- Complexity 200 203 +3
============================================
Files 17 17
Lines 1598 1585 -13
Branches 122 123 +1
============================================
- Hits 1068 1055 -13
Misses 448 448
Partials 82 82
Continue to review full report at Codecov.
|
Yi-Tseng
reviewed
Sep 28, 2020
ccascone
requested changes
Sep 29, 2020
ptf/tests/ptf/fabric_test.py
Outdated
|
|
||
| exp_pkt = pkt.copy() | ||
|
|
||
| exp_pkt[Ether].src = exp_pkt[Ether].dst |
There was a problem hiding this comment.
We should have a utility method to swap mac addresses, something like route_pkt, which greatly improves readability
ccascone
approved these changes
Sep 30, 2020
pudelkoM
reviewed
Sep 30, 2020
pudelkoM
reviewed
Sep 30, 2020
|
retest this please, codecov upload failed |
|
Waiting for Jenkins to ✅, will merge after that. @robertmacdavid can you please update the PR description, I believe this no longer applies:
|
|
retest this please, the previous run timed out (30 min) |
|
retest this please |
ccascone
added a commit
that referenced
this pull request
Oct 5, 2020
robertmacdavid
added a commit
that referenced
this pull request
Oct 21, 2020
This is a restoration of #81 that was reverted due to introducing a table read error on hardware. There are a few new changes aside from fixing said bug, include a reworking of the spgw entity namespaces and minor action signature simplification. * Minimal changes to support off-device buffering * Addressed review comments * more review comments * saving work to merge with master * added ptf test for dbuf release * better counter skip fix that I came up with by myself * some leftover crap * addressed some review comments, added another test * more review comments * addressed final review comments * missed max's comments * some pipe cleanup * added temporary read-write symmetry test * review comment * added tv generation skip for symmetry test * review comments * Updated SPGW tests to verify byte counts Co-authored-by: Robert MacDavid <robert@opennetworking.org>
bocon13
pushed a commit
that referenced
this pull request
Dec 7, 2020
This PR makes several additions to the pipeline to support off-device buffering. These changes are fully backwards-compatible with the old control plane. Actions and tables have only been added, not modified. * Added an action to the interface table for decapsulating packets returning from dbuf, so they may traverse the normal PDR and FAR pipeline * Added an action to the FAR table for redirecting packets to a buffering device * Added gateways to the ingress and egress counters so buffered packets are not double counted, since they traverse the switch twice. * Made some tweaks to reduce the pipeline depth.
bocon13
pushed a commit
that referenced
this pull request
Dec 7, 2020
bocon13
pushed a commit
that referenced
this pull request
Dec 7, 2020
This is a restoration of #81 that was reverted due to introducing a table read error on hardware. There are a few new changes aside from fixing said bug, include a reworking of the spgw entity namespaces and minor action signature simplification. * Minimal changes to support off-device buffering * Addressed review comments * more review comments * saving work to merge with master * added ptf test for dbuf release * better counter skip fix that I came up with by myself * some leftover crap * addressed some review comments, added another test * more review comments * addressed final review comments * missed max's comments * some pipe cleanup * added temporary read-write symmetry test * review comment * added tv generation skip for symmetry test * review comments * Updated SPGW tests to verify byte counts Co-authored-by: Robert MacDavid <robert@opennetworking.org>
bocon13
pushed a commit
that referenced
this pull request
Dec 7, 2020
This PR makes several additions to the pipeline to support off-device buffering. These changes are fully backwards-compatible with the old control plane. Actions and tables have only been added, not modified. * Added an action to the interface table for decapsulating packets returning from dbuf, so they may traverse the normal PDR and FAR pipeline * Added an action to the FAR table for redirecting packets to a buffering device * Added gateways to the ingress and egress counters so buffered packets are not double counted, since they traverse the switch twice. * Made some tweaks to reduce the pipeline depth.
bocon13
pushed a commit
that referenced
this pull request
Dec 7, 2020
bocon13
pushed a commit
that referenced
this pull request
Dec 7, 2020
This is a restoration of #81 that was reverted due to introducing a table read error on hardware. There are a few new changes aside from fixing said bug, include a reworking of the spgw entity namespaces and minor action signature simplification. * Minimal changes to support off-device buffering * Addressed review comments * more review comments * saving work to merge with master * added ptf test for dbuf release * better counter skip fix that I came up with by myself * some leftover crap * addressed some review comments, added another test * more review comments * addressed final review comments * missed max's comments * some pipe cleanup * added temporary read-write symmetry test * review comment * added tv generation skip for symmetry test * review comments * Updated SPGW tests to verify byte counts Co-authored-by: Robert MacDavid <robert@opennetworking.org>
bocon13
pushed a commit
that referenced
this pull request
Dec 8, 2020
This PR makes several additions to the pipeline to support off-device buffering. These changes are fully backwards-compatible with the old control plane. Actions and tables have only been added, not modified. * Added an action to the interface table for decapsulating packets returning from dbuf, so they may traverse the normal PDR and FAR pipeline * Added an action to the FAR table for redirecting packets to a buffering device * Added gateways to the ingress and egress counters so buffered packets are not double counted, since they traverse the switch twice. * Made some tweaks to reduce the pipeline depth.
bocon13
pushed a commit
that referenced
this pull request
Dec 8, 2020
bocon13
pushed a commit
that referenced
this pull request
Dec 8, 2020
This is a restoration of #81 that was reverted due to introducing a table read error on hardware. There are a few new changes aside from fixing said bug, include a reworking of the spgw entity namespaces and minor action signature simplification. * Minimal changes to support off-device buffering * Addressed review comments * more review comments * saving work to merge with master * added ptf test for dbuf release * better counter skip fix that I came up with by myself * some leftover crap * addressed some review comments, added another test * more review comments * addressed final review comments * missed max's comments * some pipe cleanup * added temporary read-write symmetry test * review comment * added tv generation skip for symmetry test * review comments * Updated SPGW tests to verify byte counts Co-authored-by: Robert MacDavid <robert@opennetworking.org>
bocon13
pushed a commit
that referenced
this pull request
Dec 8, 2020
This PR makes several additions to the pipeline to support off-device buffering. These changes are fully backwards-compatible with the old control plane. Actions and tables have only been added, not modified. * Added an action to the interface table for decapsulating packets returning from dbuf, so they may traverse the normal PDR and FAR pipeline * Added an action to the FAR table for redirecting packets to a buffering device * Added gateways to the ingress and egress counters so buffered packets are not double counted, since they traverse the switch twice. * Made some tweaks to reduce the pipeline depth.
bocon13
pushed a commit
that referenced
this pull request
Dec 8, 2020
bocon13
pushed a commit
that referenced
this pull request
Dec 8, 2020
This is a restoration of #81 that was reverted due to introducing a table read error on hardware. There are a few new changes aside from fixing said bug, include a reworking of the spgw entity namespaces and minor action signature simplification. * Minimal changes to support off-device buffering * Addressed review comments * more review comments * saving work to merge with master * added ptf test for dbuf release * better counter skip fix that I came up with by myself * some leftover crap * addressed some review comments, added another test * more review comments * addressed final review comments * missed max's comments * some pipe cleanup * added temporary read-write symmetry test * review comment * added tv generation skip for symmetry test * review comments * Updated SPGW tests to verify byte counts Co-authored-by: Robert MacDavid <robert@opennetworking.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes several additions to the pipeline to support off-device buffering. These changes are fully backwards-compatible with the old control plane. Actions and tables have only been added, not modified.