-
-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support extensions for subscriptions #2430
Closed
nrbnlulu
wants to merge
71
commits into
strawberry-graphql:main
from
nrbnlulu:support_extensions_for_subscriptions
Closed
Support extensions for subscriptions #2430
nrbnlulu
wants to merge
71
commits into
strawberry-graphql:main
from
nrbnlulu:support_extensions_for_subscriptions
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to provide backward compat, and fix other tests.
…criptions # Conflicts: # strawberry/schema/execute.py
…criptions # Conflicts: # tests/schema/extensions/test_extensions.py
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2430 +/- ##
==========================================
+ Coverage 96.30% 96.33% +0.02%
==========================================
Files 184 184
Lines 7571 7714 +143
Branches 1394 1409 +15
==========================================
+ Hits 7291 7431 +140
- Misses 179 181 +2
- Partials 101 102 +1 |
Thanks for adding the Here's a preview of the changelog: Support Extensions on subscriptions def on_execute(self):
# This part is called before the async-generator yields
yield
# This part is called after the async-generator yields Here's the preview release card for twitter: Here's the tweet text:
|
for more information, see https://pre-commit.ci
…ext-manager-hooks
…criptions # Conflicts: # RELEASE.md # strawberry/extensions/context.py
…ling default hooks.
…criptions # Conflicts: # strawberry/extensions/context.py
for more information, see https://pre-commit.ci
11 tasks
@nrbnlulu would you have time to update this PR? :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support extensions for subscriptions.
i.e:
This PR follows #2428
Notes:
resolve
Is not supported due to lack of support in graphql-coresee this issue
Types of Changes
Issues Fixed or Closed by This PR
closes #2097
Checklist