-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate websocket protocol tests #2635
Consolidate websocket protocol tests #2635
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2635 +/- ##
==========================================
- Coverage 96.33% 96.31% -0.02%
==========================================
Files 185 185
Lines 7714 7714
Branches 1421 1421
==========================================
- Hits 7431 7430 -1
- Misses 182 183 +1
Partials 101 101 |
Hi, thanks for contributing to Strawberry 🍓! We noticed that this PR is missing a So as soon as this PR is merged, a release will be made 🚀. Here's an example of Release type: patch
Description of the changes, ideally with some examples, if adding a new feature. Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :) Here's the tweet text:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kristjanvalur I can't push, can you remove the release file? 😊 |
yes, about the pushes, I'm using an organization repo for this, policy doesn't permit external pushes. |
Move tests for the websocket protocols (
graphql_ws
,graphql_transport_ws
) into a separate place (tests/websocket
)where they can be parametrized and run on the four different integration which support websockets.
Description
Previously, websocket tests were duplicated for the
aiohttp
,asgi
,fastapi
andchannels
integrations, with bothprotocols having a full set of tests in each.
Following what has been previously done with
http
, we now extend the abstractHttpClient
classes intests/http/clients
to provide async websocket functionality, parametrize the unit tests, and write them once.
This makes it easier to maintain a coherent set of unittests for the websocket protocols, while ensuring that they
do get executed for all of the available integrations.
Types of Changes
Issues Fixed or Closed by This PR
Checklist