Skip to content

Commit

Permalink
feat: improve amp addon
Browse files Browse the repository at this point in the history
  • Loading branch information
streamich committed Mar 18, 2018
1 parent 5e5b633 commit 7314eae
Showing 1 changed file with 60 additions and 0 deletions.
60 changes: 60 additions & 0 deletions addon/amp.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,56 @@ var removeImportant = function (renderer) {
};
};

var warnOnReservedSelectors = function (renderer) {
var putRaw = renderer.putRaw;

renderer.putRaw = function (rawCssRule) {
var pos = rawCssRule.indexOf('{');

if (pos < 0)
return putRaw(rawCssRule);

var selectors = ' ' + rawCssRule.substr(0, pos);

if (selectors.match(/\s\.-amp-/g)) {
console.error(
'Detected class name that starts with "-amp-". ' +
'Class names starting with "-amp-" are reserved from AMP components. ' +
rawCssRule
);
}

if (selectors.match(/\si-amp-/g)) {
console.error(
'Detected CSS selector that matches "i-amp-" elements. ' +
'Slectors for "i-amp-" elements are reserved from AMP components. ' +
rawCssRule
);
}

return putRaw(rawCssRule);
};
};

var removeReservedSelectors = function (renderer) {
var putRaw = renderer.putRaw;

renderer.putRaw = function (rawCssRule) {
var pos = rawCssRule.indexOf('{');

if (pos < 0)
return putRaw(rawCssRule);

var selectors = ' ' + rawCssRule.substr(0, pos);

if (selectors.match(/\s\.-amp-/g) || selectors.match(/\si-amp-/g)) {
return;
}

return putRaw(rawCssRule);
};
};

var warnOnBanned = function (renderer) {
var decl = renderer.decl;

Expand Down Expand Up @@ -84,6 +134,16 @@ exports.addon = function (renderer, config) {
removeImportant(renderer);
}

// Warn on reserved selectors.
if (process.env.NODE_ENV !== 'production') {
warnOnReservedSelectors(renderer);
}

// Remove reserved selectors ".-amp-" and "i-amp-".
if (config.removeReserved) {
removeReservedSelectors(renderer);
}

// Warn on banned CSS properties.
if (process.env.NODE_ENV !== 'production') {
warnOnBanned(renderer);
Expand Down

0 comments on commit 7314eae

Please sign in to comment.