Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search fix #78

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Search fix #78

merged 1 commit into from
Oct 13, 2021

Conversation

etchalon
Copy link
Contributor

@etchalon etchalon commented Oct 13, 2021 •
edited
Loading

Fixes the search feature of the site:

  1. Use tabIndex instead of tabindex
  2. New settings to match Algolia API.
  3. Includes an exported Algolia search index configuration, in case the configuration gets lost again. It should be copied over whenever the index is rebuilt, but maybe there's a bug? Should test.

@randyzwitch
Copy link
Contributor

LGTM

@randyzwitch randyzwitch merged commit 21e7815 into main Oct 13, 2021
@snehankekre snehankekre mentioned this pull request Oct 14, 2021
Closed
@snehankekre snehankekre deleted the search-fix branch October 14, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvst tvst Awaiting requested review from tvst

@imjuangarcia imjuangarcia Awaiting requested review from imjuangarcia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etchalon @randyzwitch