Migrate disconnect and disabled from cypress to playwright #8732
Conversation
willhuang1997
changed the title
willhuang1997
force-pushed
the
playwright/disconnect
branch
from
e879575
to
aa030a8
Compare
sfc-gh-wihuang
changed the title
There was a problem hiding this comment.
Overall, this looks good. But I think these two tests can be combined to one since they are both testing disconnection. I would probably combine it into something like websocket_disconnect test file to make it a bit more obvious what it is testing. Maybe it's even enough to just have the test_disconnecting_disables_widgets_correctly since it seems to include the other logic.
Sounds good. Will do that. Thanks |
| expect(app.get_by_test_id("stMarkdown").first).to_contain_text("Value 1: 25") | ||
|
|
||
| expect(app.get_by_test_id("stConnectionStatus")).not_to_be_visible() | ||
| app.evaluate("window.streamlitDebug.shutdownRuntime()") |
There was a problem hiding this comment.
nit: maybe add a comment here that calling this will disconnect the WebSocket connection -> which should put all elements into disabled mode.
…#8732) ## Describe your changes ## GitHub Issue Link (if applicable) ## Testing Plan - Explanation of why no additional tests are needed - Unit Tests (JS and/or Python) - E2E Tests - Any manual testing needed? --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license. --------- Co-authored-by: willhuang1997 <willhuang1997@gmail.com>
Describe your changes
GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.