refactor: Bump terraform sdk to version 2 #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodece
requested review from
addisonj,
sijie,
zymap and
a team
as code owners
nodece
force-pushed
the
sdk-v2
branch
2 times, most recently
from
c3f7af1
to
551138f
Compare
sijie
reviewed
Nov 10, 2021
nodece
force-pushed
the
sdk-v2
branch
8 times, most recently
from
3228eab
to
4402f52
Compare
chore: Update gitignore refactor: Avoid mixing sets and lists on permission_grant chore: Update tests expectations after upgrade to newer api versions tests: Add a small test for hashcode function ci: Install tools outside of modules refactor: Upgrade pulsarctl and remove api_version dependency Update go version and how tools get installed
nodece
force-pushed
the
sdk-v2
branch
2 times, most recently
from
f35cba8
to
e8c96b0
Compare
maxsxu
reviewed
May 19, 2022
|
@nodece Max helped take a reivew on your PR, pls check his comments. |
|
@jrsdav @jdmaguire Hi Joey, John, Platform eng Zixuan is working on terraform SDK upgrade and wanna release a new version of terraform-provider-pulsar. Could you also help take a look at this PR since Platform team doesn't have much experience on terraform. |
|
@maxsxu Thanks for your review, these request has been addressed. |
maxsxu
previously approved these changes
May 24, 2022
maxsxu
approved these changes
Jul 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #36
This PR was implemented based on #30.