Skip to content

Conversation

DaisyDomergue
Copy link
Member

No description provided.

@linear
Copy link

linear bot commented Jan 7, 2022

DEVOP-123 Add Dependabot for DATAv2 repo

Add Dependabot for GitHub Actions and Node/Javascript.

@DaisyDomergue DaisyDomergue requested a review from kare January 7, 2022 15:33
@kare
Copy link
Contributor

kare commented Jan 8, 2022

About the conventional commit title:

build:fix:dependabot configuration to include conventional commit

  • Leave a space after the prefix
  • There can only be one prefix
  • Prefix can have a scope, but don't worry about scopes at this point. Just learn to use prefixes naturally.
  • Prefix fix is for bug fixes. Bug fixes don't occur as part of PR development. Errors in code are a natural part of the development cycle.
  • Significant and/or long lasting development bug fix commits can and should be prefixed with fix.
  • Prefix fix should be used when fixing and releasing a bug fix version of the software.
  • Use common sense when prefixing commits.

Note that even if the build system has a bug in it. The fixing commit should be prefixed with: build. Same goes for CI with the prefix ci.

If the commit message contains a body it should be separated from the title line with an empty line.

Reword the commit title for example? "build: update Dependabot configuration for Npm"

Reword the PR title "DEVOP-123: update Dependabot configuration for Npm"

Convention is to start the sentence with a lowercase letter and words that are usually capitalised should be capitalised (for example: GitHub, Dependabot) to make greping powerful. Title sentence should not end in a dot.

The power of Git is to rewrite the history so the reworded commit title can be modified with git commit --amend -v and needs to be force pushed (git push -f). Rewriting history is a very powerful and dangerous tool. Sloppy interactive rebase can lead to lost commits! Never force push master/main branch!

You can also include the update for code review comment in the same commit with:
git commit -av --amend or git add .github/dependabot.yaml && git commit -v --amend and then force push the review change.

git reflog might help with a failed force push.

@DaisyDomergue DaisyDomergue changed the title build:fix:dependabot configuration to include conventional commit DEVOP-123: update Dependabot configuration for Npm Jan 11, 2022
@DaisyDomergue DaisyDomergue force-pushed the DEVOP-123-CI-FIX-Dependabot-Configuration branch from be25d41 to 24b9b2d Compare January 11, 2022 13:49
@DaisyDomergue DaisyDomergue force-pushed the DEVOP-123-CI-FIX-Dependabot-Configuration branch from 24b9b2d to 0ec8953 Compare January 11, 2022 13:52
@DaisyDomergue DaisyDomergue requested a review from kare January 11, 2022 13:55
Copy link
Contributor

@kare kare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaisyDomergue DaisyDomergue merged commit 0b3c388 into main Jan 11, 2022
@DaisyDomergue DaisyDomergue deleted the DEVOP-123-CI-FIX-Dependabot-Configuration branch January 11, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants