Skip to content

fixes requested by limechain audit #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2021
Merged

fixes requested by limechain audit #3

merged 1 commit into from
Jul 5, 2021

Conversation

Isentrope1
Copy link
Contributor

  • fix Solidity version (uses 0.8.6, latest)
  • upgradeFrom is external

@Isentrope1 Isentrope1 requested review from jtakalai and samt1803 July 5, 2021 11:21
jtakalai
jtakalai approved these changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@jtakalai jtakalai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samt1803
samt1803 approved these changes Jul 5, 2021
View reviewed changes
Copy link

@samt1803 samt1803 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@Isentrope1 Isentrope1 merged commit 6af417b into main Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@samt1803 samt1803 samt1803 approved these changes

@jtakalai jtakalai jtakalai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Isentrope1 @samt1803 @jtakalai