Add chain "slug"; use proper chain key for Polygon Amoy (in local configs) #1976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's polygonAmoy not just amoy. We'll have to handle links later.
Slug is a piece to be used in urls. In our case `?chain=polygonAmoy` is gonna be `?chain=amoy`.
|
@tumppi after throwing a second look I now see that it does change the logic (see There is one more PR coming shortly addressing chain display names, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I eliminate the special case where we'd use
amoyas a chain key (fake) for what should've beenpolygonAmoy(the actual chain key for Polygon Amoy testnet).I do so in the following way:
slugto config extension (topolygonAmoy's config) – seechains.yml.getChainKeyto map it to the actual chain key, and inrouteOptionsfor proper search query output.This way any chain (new or existing) can have a short preferred identifier to be used in urls. All for the sake of making adding new chains easier.
In addition, the
getPreferredChainNamegot renamed togetChainKeyand refactored. It now always returns aChainKey. It defaults todefaultChainKeyif it fails to identify the candidate, and warns about such situation viaconsole.warn.