Chain's display name done right #1977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I also move some coingeco stuff into chain config extensions so that we don't handle any edge cases and all local chain config customisations are in one place.
Consistent naming.
These tests are really checking if expectations meet reality.
jtakalai
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now have the
getChainDisplayNamethat uses local chain config extensions (seechains.yml) for any local per-chain human readable name customisation.We used to have
formatChainName,chain.name(modded inchains.ts), and theethereumNetworksid-to-name map. Now it's all packed nicely into the new utility function.This should help us a bunch.
I've also identified that we've been using human readable names to key sale points in the "project" part of the hub. Not ideal, to say the least. Switched it up to the chain key.