Eth 228 streamregistry contract upgrade #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- trusted methods bulk create streams and bulk set permissions without setting metadata - clean up all-false/expired permission on setting it
|
To look at the diff of the contract V2 and V3 can be compared in VSCode. |
samt1803
added a commit
that referenced
this pull request
Feb 15, 2022
…eams_to_ocr * origin/master: ETH-244: simplify network contracts workspace (#153) replaced an outdated signing library with its new version, replaces a require with import, changed a few types around to make it work (#151) Eth 228 streamregistry contract upgrade (#150) build: update dependencies (#147) chore: update .gitignore build(deps-dev): bump eslint-config-streamr-nodejs (#124) build(deps-dev): bump @typescript-eslint/eslint-plugin (#142) build(deps-dev): bump @types/mocha in /packages/smartcontracts (#125) build(deps): bump dotenv in /packages/chainlink-ens-external-adapter (#141) fix: fix prod deployment script; Add README part on how to do the prod deployment. fix: small fix in theGraph: when through trusted account implcitly creating a stream by setting its metadata the createdAt timestamp was not set. Now it will be feat: added created-at and updated-at timestamps to stream in subgraph (#139) Update storage node metadata #140 ci: bump actions/setup-node from 2.5.0 to 2.5.1 (#110) # Conflicts: # package-lock.json # package.json
samt1803
added a commit
that referenced
this pull request
Feb 23, 2022
* master-3: (44 commits) fix: fixed bug in subgraph if permission is set on a non-existing stream. It will now ignore the eth event release: @streamr/config 0.0.1 build(config): version is not required by 'npm publish' (#170) feat: add @streamr/config package (#84) comment: updated deployed-on comment in StreamregistryV3 add V3 streamregistry to preloaded parity chain; fix buildscript some more fixed docker-dev-chain-init script ETH-244: simplify network contracts workspace (#153) replaced an outdated signing library with its new version, replaces a require with import, changed a few types around to make it work (#151) Eth 228 streamregistry contract upgrade (#150) build: update dependencies (#147) chore: update .gitignore build(deps-dev): bump eslint-config-streamr-nodejs (#124) build(deps-dev): bump @typescript-eslint/eslint-plugin (#142) build(deps-dev): bump @types/mocha in /packages/smartcontracts (#125) build(deps): bump dotenv in /packages/chainlink-ens-external-adapter (#141) fix: fix prod deployment script; Add README part on how to do the prod deployment. fix: small fix in theGraph: when through trusted account implcitly creating a stream by setting its metadata the createdAt timestamp was not set. Now it will be feat: added created-at and updated-at timestamps to stream in subgraph (#139) Update storage node metadata #140 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streamregistry: bulk set permissions + cleanup
1)
It should be possible to set multiple permissions for multiple streams in one transaction call. The caller needs to have grant permission on all of the streams.
The method should be added in the contract (it should be able to call the exisiting one-stream method in a loop) and in the client. (contracts need to be upgraded)
This would help applications to set permissions to many streams in one transaction, solving a possible situation where a user needs to sign many transactions with metamask, which not userfriendly.
new seperate methods to bulk create streams and bulk set permissions for the migrations. The old methods used inputs where there are cases wehere the stream metadata needs be set as parameter for each permission update on a stream-user combination, resulting in possible hundreds of time of overwriting the metadata with itself.
clean up permissions when setting them, and then it results in the permission for the user being all false/expired