Skip to content

Conversation

kare
Copy link
Contributor

@kare kare commented Mar 7, 2022

No description provided.

kare added 2 commits March 7, 2022 14:55
- Rename: loadConfig(env) to Chains.load(env)
- Rename: use capital case for acronym classes
    - RpcEndpoint -> RPCEndpoint
    - RpcProtocol -> RPCProtocol
    - RpcEndpoint -> RPCEndpointJSON
    - Add Chains.getRPCEndpointsByProtocol(RPCProtocol): RPCEndpoint[]
    - Network -> NetworkJSON
    - Chain -> ChainJSON
- Add classes:
    - Chain
    - Network
    - ChainsFactory
    - RPCEndpoint
- Use concrete classes that implement JSON interfaces in public API
- Use interfaces for parsing JSON file
@linear
Copy link

linear bot commented Mar 7, 2022

NET-722 config: Allow multiple RPC addresses

Replace RPC URL string fields with a string array:

@kare kare merged commit 533ded9 into master Mar 7, 2022
@kare kare deleted the net-722-config-allow-multiple-rpc-addresses branch March 7, 2022 14:58
samt1803 added a commit that referenced this pull request Mar 9, 2022
* master-3: (21 commits)
  feat(config): load config by detecting environment from NODE_ENV (#171)
  feat(config): allow multiple RPC addresses (#201)
  fix: fixed regression bug in migration script
  ci: bump actions/checkout from 2.4.0 to 3 (#192)
  ci: bump actions/stale from 4.1.0 to 5 (#191)
  Eth 138 migrate streams to ocr (#190)
  ci: bump actions/setup-node from 2.5.1 to 3 (#189)
  ci: remove root Npm package from Dependabot config
  ci: increase Dependabot PR limit for smartcontracts
  docs(config): Use correct nomenclature in README
  test(config): rename test
  build: update package.json files based on versions in package-lock.json (#176)
  build(deps-dev): bump solidity-coverage from 0.7.17 to 0.7.20 (#174)
  build(deps-dev): bump @types/node from 16.11.7 to 16.11.25 (#172)
  fix: fixed bug in subgraph if permission is set on a non-existing stream. It will now ignore the eth event
  release: @streamr/config 0.0.1
  build(config): version is not required by 'npm publish' (#170)
  feat: add @streamr/config package (#84)
  comment: updated deployed-on comment in StreamregistryV3
  add V3 streamregistry to preloaded parity chain; fix buildscript some more
  ...

# Conflicts:
#	.gitignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant