refactor: rename flagWithMetadata
#630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtakalai
approved these changes
Sep 13, 2023
samt1803
added a commit
that referenced
this pull request
Sep 15, 2023
…lthcheck * origin/master: (32 commits) release(network-contracts): v6.1.0 release(config): @streamr/config 4.0.5 ETH-585 docker images build and test in CI (#616) Eth 596 subgraph fixeschanges (#631) fix: merge hazard from flagWithMetadata PR cleanup: reorder setParam function, uint256 -> uint in Policies feat: make slashing fraction configurable (#624) rename flagWithMetadata -> flag, and remove the previous implementation (#630) release(config): @streamr/config 4.0.4 streamr 1.0 mumbai deployment addresses update Modularize operator (#629) doc: add clean step to push-to-docker-hub instructions release(network-contracts): 6.0.1 fix: remove accidentally duplicated function Eth 584 erc677 in operator factory (#627) added hardhat-contract-sizer to contract build process ETH-579: Check Operator contract function guards (#628) deoc: added addresses preloaded with DATA to fastchain readme release(config): @streamr/config 4.0.3 new addresses for mumbai streamr 1.0 deployment ...
samt1803
added a commit
that referenced
this pull request
Sep 15, 2023
* ens-sync-script-healthcheck: (39 commits) codereview changerequest changes release(network-contracts): v6.1.0 release(config): @streamr/config 4.0.5 ETH-585 docker images build and test in CI (#616) Eth 596 subgraph fixeschanges (#631) fix: merge hazard from flagWithMetadata PR cleanup: reorder setParam function, uint256 -> uint in Policies feat: make slashing fraction configurable (#624) rename flagWithMetadata -> flag, and remove the previous implementation (#630) release(config): @streamr/config 4.0.4 streamr 1.0 mumbai deployment addresses update Modularize operator (#629) doc: add clean step to push-to-docker-hub instructions release(network-contracts): 6.0.1 fix: remove accidentally duplicated function Eth 584 erc677 in operator factory (#627) added hardhat-contract-sizer to contract build process ETH-579: Check Operator contract function guards (#628) deoc: added addresses preloaded with DATA to fastchain readme release(config): @streamr/config 4.0.3 ... # Conflicts: # .github/workflows/ci.yaml # packages/network-contracts/package.json
samt1803
added a commit
that referenced
this pull request
Sep 18, 2023
* master: Add a test that parallels an Operator plugin test in network repo (#633) updated ens-sync-script to work with fastchain (#615) Sponsorship fix: don't let _reduceStakeBy revert when over-slashing (#632) doc: update build and publish images description doc: publish instructions release(network-contracts): v6.1.0 release(config): @streamr/config 4.0.5 ETH-585 docker images build and test in CI (#616) Eth 596 subgraph fixeschanges (#631) fix: merge hazard from flagWithMetadata PR cleanup: reorder setParam function, uint256 -> uint in Policies feat: make slashing fraction configurable (#624) rename flagWithMetadata -> flag, and remove the previous implementation (#630) release(config): @streamr/config 4.0.4 streamr 1.0 mumbai deployment addresses update # Conflicts: # package-lock.json # packages/network-subgraphs/subgraph.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed the method to
flagas all flagging needs to use that method in practice. There was already aflagmethod which didn't have metadata parameter. That method is now removed.The inspection logic needs that there is partition information available, and we deliver that in the
metadatafield. There are currently no on-chain validations to the metadata. In that sense it is similar to e.g.StreamRegistry#createStreamwhich needs the metadata for off-chain use, and validation is implemented off-chain.