Skip to content

Fix other bad alias. #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2021
Merged

Fix other bad alias. #132

merged 1 commit into from
Apr 30, 2021

Conversation

timoxley
Copy link
Contributor

@timoxley timoxley commented Apr 30, 2021 •
edited
Loading

I even have it in the comment: aliases should be plural to reduce possibility of conflicts with service names

🤦

Using this version:

sdd log --dry-run broker-node-no-storage-1
docker-compose --ansi never logs  -t --tail=1000 broker-node-no-storage-1

kare
kare approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@kare kare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timoxley timoxley merged commit ef836e4 into master Apr 30, 2021
@timoxley timoxley deleted the fix-other-bad-alias branch April 30, 2021 12:16
kare pushed a commit that referenced this pull request Aug 2, 2021
@timoxley @kare
Fix other bad alias. broker-node-no-storage-1 -> broker-broker-node-n…
afd8d16 
…o-storage-1 (#132)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kare kare kare approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@timoxley @kare