-
Notifications
You must be signed in to change notification settings - Fork 6
added ens-sync-fastchain container entry #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it have a health check? I wrote a quick attempt at something like that, though really it's kind of hard to know if it REALLY is healthy before there is traffic -___- see #617
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this ETH-568?
We should add some kind of health check at least. Adding a few comments to what @jtakalai is working on in streamr-dev/network-contracts#617. Could we add that here? The file writing approach there is better than having no health check.
I think since it has its own PR, we could just leave it out from here. Let's get this one merged. |
Having the health check here is kind of important if we want to re-enable the skipped tests in client related to this service (mainly https://github.com/streamr-dev/network/blob/streamr-1.0/packages/client/test/end-to-end/StreamRegistry.test.ts#L116). Unless we have another way to verify that the service is running before starting the test run? |
added healthcheck to container |
main PR is streamr-dev/network-contracts#615
ticket for that is https://linear.app/streamr/issue/ETH-568/add-ens-stream-creation-support-to-fast-chain