Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add several tech companies #1269

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Add several tech companies #1269

merged 1 commit into from
Jul 26, 2022

Conversation

calvinballing
Copy link
Collaborator

@calvinballing calvinballing commented Jul 22, 2022 •
edited by Jason3S
Loading

Adds the following tech companies:

Expensify
HelloSign
Mailtrap
Mixpanel
SmartyStreets

BEGIN_COMMIT_OVERRIDE
fix: Add several tech company names and their tools
END_COMMIT_OVERRIDE

@calvinballing
Copy link
Collaborator Author

I am wondering if these might fit better in the software tools section. If that seems better let me know and I can do that instead

Jason3S
Jason3S requested changes Jul 23, 2022
View reviewed changes
Copy link
Collaborator

@Jason3S Jason3S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Expensify and Mixpanel are companies.
Smarty has a tool called SmartyStreets.
The rest seem to be tools / products / services.

dictionaries/companies/src/companies.txt Outdated
@@ -708,6 +709,7 @@ Health Net, Inc.
Healthpeak Properties
HeBei Iron & Steel Group
Heineken Holding
HelloSign
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a product and as you suggested, it might be better in the tools dictionary.
In the future, it might be worth it to have product dictionaries based upon industry.

dictionaries/companies/src/companies.txt Outdated
@@ -954,6 +956,7 @@ Macy's
Macy's, Inc.
Magna International
Mail.ru Group
Mailtrap
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another product / tool.

@Jason3S Jason3S merged commit 5648103 into streetsidesoftware:main Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jason3S Jason3S Jason3S approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calvinballing @Jason3S