Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add Lexer to Software Terms dictionaries #3266

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

Encephala
Copy link
Contributor

Add/Fix Dictionary

Dictionary: en_GB and en_US

Description

The word Lexer is commonly used in programming, but wasn't in the dictionaries.

References

  • None

Checklist

  • By submitting this pull-request, you agree to follow our Code of Conduct
  • Verify that the title starts with the correct prefix:
    • fix: - for minor changes like adding words or fixing spelling issues.
    • feat: - for a significant change like adding a whole new set of words to a dictionary.
    • feat!: - for breaking changes, like file format or licensing changes.
    • chore: - for changes that do not impact the content of dictionaries.

@nschonni
Copy link
Collaborator

nschonni commented Jun 8, 2024

@Jason3S
Copy link
Collaborator

Jason3S commented Jun 8, 2024

@Encephala,

Thank you for the PR.

I checked to see which dictionaries currently have Lexer using cspell trace lexer. Looks like cpp, en_us, and java.

image

As Nick points out, software terms is a good place. Or, since it is already in en_us, adding it to dictionaries/en_shared/src/shared-additional-words.txt might be a good idea, so that it is added to all variants of English. I'm open to either option.

Other versions of the word (lexes, lexing) were already present,
now the noun is too.
@Encephala
Copy link
Contributor Author

Ah I looked for the word existing in dictionaries but couldn't find it,m ust've not looked hard enough.

I like Nick's suggestion, especially considering other forms of the word were already in that dictionary like lexes and lexing.
Force pushed to fix!

@Jason3S Jason3S changed the title fix: add Lexer to English dictionaries fix: add Lexer to Software Terms dictionaries Jun 9, 2024
@Jason3S Jason3S merged commit 341fcb1 into streetsidesoftware:main Jun 9, 2024
8 checks passed
@Jason3S
Copy link
Collaborator

Jason3S commented Jun 9, 2024

Ah I looked for the word existing in dictionaries but couldn't find it,m ust've not looked hard enough.

Finding words in dictionaries is a challenge, that is why the trace command exists.

I like Nick's suggestion, especially considering other forms of the word were already in that dictionary like lexes and lexing. Force pushed to fix!

👍

@github-actions github-actions bot mentioned this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants