feat!: Change the API to match modern JavaScript #970
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this library was created functions like
String.matchAll
were not widely available.This API change is to have the worker methods match
String.match
,String.matchAll
,RegExp.exec
.The new API
Migration from 3.x to 4.x
The order of the parameters have changed to closer match JavaScript.
match
methods have the text first followed by the RegExp.execRegExpOnWorker
->workerMatchAll
execRegExpMatrixOnWorker
-> Deleted - UseworkerMatchAllArray
RegExpWorker.execRegExpMatrix
-> Deleted - UseRegExpWorker.matchAllArray
RegExpWorker.matchRegExp
-> Deleted -- it returned number ranges instead of matches.RegExpWorker.matchRegExpArray
-> Deleted -- it returned number ranges instead of matches.RegExpWorker.execRegExp
->RegExpWorker.matchAll