Multilines don't play nicely with vim-go

[shmup]

I also opened the issue over there, but figured I'd additionally post here.

fatih/vim-go#168

I attached two screenshots. One shows how go test renders in a terminal, and the other when using :GoTest within vim. I'm using testify mostly for assert functionality.

I chatted with fatih a bit in #go-nuts, and it was said that vim-go has pretty basic support for multilines.

[tylerstillwater]

Right. The same thing happens in Sublime Text. The reason is that testify uses \b and \r to overwrite the output of the testing framework since it prints out the wrong location. Testify replaces that with the correct location that it finds.

I am not sure what, if anything, can be done about this. Any thoughts?

[shmup]

fatih responded basically saying that I could add a command like :GoTestify which would parse the output. He raised a good point. Other testing suites may have other issues, and he doesn't want to spend time with all of them.

For now I'm just going to use a simple wrapper: https://gist.github.com/karlseguin/5128442 but eventually I'd like to get back to testify.

I'll admit I haven't given the solution much thought. Maybe this weekend.

[tylerstillwater]

He says we need a testing compatible output. I agree with that. We will be addressing this in #84.

[yasker]

Would there be a update for this issue in the near future? It becomes the major reason currently I am reluctant to use testify. I just tried it and hit by this issue immediately, have to switch back to standard framework...

[nmiyake]

This affects running tests directly in IntelliJ as well.

I believe this is a real issue with alignment -- it has to do with outputting tabs instead of aligning properly via spaces for output. The update to put "expected:" and "received:" on different lines helps somewhat, but the issue still exists:

From terminal:

Using IntelliJ runner:

I have code that I believe fixes this -- it works in the IntelliJ runner and terminal, maintains the same output, and I believe it is more functionally correct. Will open as a PR shortly.

[rantav]

I have this issue as well (using vim-go), is there a fix for that?

[nmiyake]

@rantav can you check out my branch with the fix (https://github.com/nmiyake/testify/tree/fixFailOutput, which is the basis for the PR #364) and see if that resolves the issue? I can try to set up vim-go and see if I can repro the issue and if my fix addresses it.

I opened the potential fix PR in late October but unfortunately have not received any feedback on it yet.

[rantav]

Thanks @nmiyake but unfortunately for vim-go that still doesn't seem to work...

[sashaweiss]

Hey all - was there resolution on this, or a lasting workaround? Running into this myself currently, and it's driving me nuts.

[davidbanham]

@sashaweiss Yep, was fixed here:

a726187