Speed up didToProfile in large queues #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This speeds up the `didToProfile` helper on the queue page if the queue is large (say over 500 accounts). I’m not quite sure why the current solution is this slow (up to 3s to rerender) since we should only be looking at 2.25 million lookups maxium in a queue of n = 1500. Generating the map initially takes around 2ms and any lookups via `didToProfile` go down from around 40ms to <0.2ms.
Deploying bsky-furry-feed-admin with
|
| Latest commit: |
28f5b4d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0d54fa8f.bsky-furry-feed-admin.pages.dev |
| Branch Preview URL: | https://kev-speed-up-didtoprofile-la.bsky-furry-feed-admin.pages.dev |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Deploying bsky-furry-feed-info with
|
| Latest commit: |
28f5b4d
|
| Status: | 🚫 Build failed. |
strideynet
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up the
didToProfilehelper on the queue page if the queueis large (say over 500 accounts). I’m not quite sure why the current
solution is this slow (up to 3s to rerender) since we should only be
looking at 2.25 million lookups maxium in a queue of n = 1500.
Generating the map initially takes around 2ms and any lookups via
didToProfilego down from around 40ms to <0.2ms.