Skip to content

Add option to ignore child ordering in comparisons #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 1, 2019

Conversation

stringbean
Copy link
Owner

This adds a new option (IgnoreChildOrder) that causes child nodes to be sorted before any comparisons are performed.

Fixes #2

@codecov-io
Copy link

codecov-io commented Oct 1, 2019

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #4   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      7    +2     
  Lines          75    104   +29     
  Branches        7     13    +6     
=====================================
+ Hits           75    104   +29
Impacted Files Coverage Δ
...pledragon/xml/compare/NormalisedNodeOrdering.scala 100% <100%> (ø)
.../purpledragon/xml/compare/options/DiffOption.scala 100% <100%> (ø) ⬆️
...ain/scala/software/purpledragon/xml/XmlUtils.scala 100% <100%> (ø)
...software/purpledragon/xml/compare/XmlCompare.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 324cc40...fec91b9. Read the comment docs.

@stringbean stringbean marked this pull request as ready for review October 1, 2019 14:57
@stringbean stringbean merged commit 571701c into master Oct 1, 2019
@stringbean stringbean deleted the ignore-child-order branch October 1, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ignoring order of child elements in diffs
2 participants