Updated bcrypt from v3.1 to v3.1.12 #520
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Personally I was getting 500 erorrs when trying to set up the password, and was getting the following InvalidHash errors. This resolution in an unrelated project that also uses bcrypted resolved this issue for me: heartcombo/devise#4861 ``` Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: D, [2020-09-03T10:16:28.318049 #2019485] DEBUG -- : SQL (0.4ms) DELETE FROM "users" Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: 2020-09-03 10:16:28 - BCrypt::Errors::InvalidHash - invalid hash: Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/bcrypt-3.1.11/lib/bcrypt/password.rb:60:in `initialize' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/bcrypt-3.1.11/lib/bcrypt/password.rb:46:in `new' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/bcrypt-3.1.11/lib/bcrypt/password.rb:46:in `create' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/activemodel-4.2.10/lib/active_model/secure_password.rb:125:in `password=' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/activerecord-4.2.10/lib/active_record/attribute_assignment.rb:54:in `public_send' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/activerecord-4.2.10/lib/active_record/attribute_assignment.rb:54:in `_assign_attribute' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/activerecord-4.2.10/lib/active_record/attribute_assignment.rb:41:in `block in assign_attributes' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/activerecord-4.2.10/lib/active_record/attribute_assignment.rb:35:in `each' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/activerecord-4.2.10/lib/active_record/attribute_assignment.rb:35:in `assign_attributes' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/activerecord-4.2.10/lib/active_record/core.rb:566:in `init_attributes' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/activerecord-4.2.10/lib/active_record/core.rb:281:in `initialize' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/activerecord-4.2.10/lib/active_record/inheritance.rb:61:in `new' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/activerecord-4.2.10/lib/active_record/inheritance.rb:61:in `new' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/activerecord-4.2.10/lib/active_record/persistence.rb:33:in `create' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/stringer/app/commands/users/create_user.rb:10:in `create' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/stringer/app/controllers/first_run_controller.rb:23:in `block (2 levels) in <class:Stringer>' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/sinatra-1.4.8/lib/sinatra/base.rb:1611:in `call' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/sinatra-1.4.8/lib/sinatra/base.rb:1611:in `block in compile!' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/sinatra-1.4.8/lib/sinatra/base.rb:975:in `block (3 levels) in route!' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/sinatra-1.4.8/lib/sinatra/base.rb:994:in `route_eval' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/sinatra-1.4.8/lib/sinatra/base.rb:975:in `block (2 levels) in route!' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/sinatra-1.4.8/lib/sinatra/base.rb:1015:in `block in process_route' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/sinatra-1.4.8/lib/sinatra/base.rb:1013:in `catch' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/sinatra-1.4.8/lib/sinatra/base.rb:1013:in `process_route' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/sinatra-1.4.8/lib/sinatra/base.rb:973:in `block in route!' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/sinatra-1.4.8/lib/sinatra/base.rb:972:in `each' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/sinatra-1.4.8/lib/sinatra/base.rb:972:in `route!' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/sinatra-1.4.8/lib/sinatra/base.rb:1085:in `block in dispatch!' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/sinatra-1.4.8/lib/sinatra/base.rb:1067:in `block in invoke' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/sinatra-1.4.8/lib/sinatra/base.rb:1067:in `catch' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/sinatra-1.4.8/lib/sinatra/base.rb:1067:in `invoke' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/sinatra-1.4.8/lib/sinatra/base.rb:1082:in `dispatch!' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/sinatra-1.4.8/lib/sinatra/base.rb:907:in `block in call!' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/sinatra-1.4.8/lib/sinatra/base.rb:1067:in `block in invoke' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/sinatra-1.4.8/lib/sinatra/base.rb:1067:in `catch' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/sinatra-1.4.8/lib/sinatra/base.rb:1067:in `invoke' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/sinatra-1.4.8/lib/sinatra/base.rb:907:in `call!' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/sinatra-1.4.8/lib/sinatra/base.rb:895:in `call' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/rack-protection-1.5.5/lib/rack/protection/xss_header.rb:18:in `call' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/rack-protection-1.5.5/lib/rack/protection/base.rb:49:in `call' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/rack-protection-1.5.5/lib/rack/protection/base.rb:49:in `call' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/rack-protection-1.5.5/lib/rack/protection/path_traversal.rb:16:in `call' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/rack-protection-1.5.5/lib/rack/protection/json_csrf.rb:18:in `call' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/rack-protection-1.5.5/lib/rack/protection/base.rb:49:in `call' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/rack-protection-1.5.5/lib/rack/protection/base.rb:49:in `call' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/rack-protection-1.5.5/lib/rack/protection/frame_options.rb:31:in `call' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/rack-1.6.12/lib/rack/session/abstract/id.rb:252:in `context' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/rack-1.6.12/lib/rack/session/abstract/id.rb:247:in `call' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/rack-1.6.12/lib/rack/logger.rb:15:in `call' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/rack-1.6.12/lib/rack/commonlogger.rb:33:in `call' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/sinatra-1.4.8/lib/sinatra/base.rb:219:in `call' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/sinatra-1.4.8/lib/sinatra/base.rb:212:in `call' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/rack-1.6.12/lib/rack/head.rb:13:in `call' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/rack-1.6.12/lib/rack/methodoverride.rb:22:in `call' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/sinatra-1.4.8/lib/sinatra/base.rb:182:in `call' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/sinatra-1.4.8/lib/sinatra/base.rb:2013:in `call' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/sinatra-1.4.8/lib/sinatra/base.rb:1487:in `block in call' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/sinatra-1.4.8/lib/sinatra/base.rb:1787:in `synchronize' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/sinatra-1.4.8/lib/sinatra/base.rb:1487:in `call' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/rack-1.6.12/lib/rack/urlmap.rb:66:in `block in call' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/rack-1.6.12/lib/rack/urlmap.rb:50:in `each' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/rack-1.6.12/lib/rack/urlmap.rb:50:in `call' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/unicorn-5.4.0/lib/unicorn/http_server.rb:606:in `process_client' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/unicorn-5.4.0/lib/unicorn/http_server.rb:701:in `worker_loop' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/unicorn-5.4.0/lib/unicorn/http_server.rb:549:in `spawn_missing_workers' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/unicorn-5.4.0/lib/unicorn/http_server.rb:142:in `start' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/unicorn-5.4.0/bin/unicorn:126:in `<top (required)>' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/bin/unicorn:23:in `load' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/bin/unicorn:23:in `<top (required)>' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/2.6.0/bundler/cli/exec.rb:74:in `load' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/2.6.0/bundler/cli/exec.rb:74:in `kernel_load' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/2.6.0/bundler/cli/exec.rb:28:in `run' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/2.6.0/bundler/cli.rb:463:in `exec' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/2.6.0/bundler/vendor/thor/lib/thor/command.rb:27:in `run' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/2.6.0/bundler/vendor/thor/lib/thor/invocation.rb:126:in `invoke_command' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/2.6.0/bundler/vendor/thor/lib/thor.rb:387:in `dispatch' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/2.6.0/bundler/cli.rb:27:in `dispatch' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/2.6.0/bundler/vendor/thor/lib/thor/base.rb:466:in `start' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/2.6.0/bundler/cli.rb:18:in `start' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/bundler-1.17.2/exe/bundle:30:in `block in <top (required)>' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/2.6.0/bundler/friendly_errors.rb:124:in `with_friendly_errors' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/bundler-1.17.2/exe/bundle:22:in `<top (required)>' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/bin/bundle:23:in `load' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: /home/stringer/.rbenv/versions/2.6.5/bin/bundle:23:in `<main>' Sep 03 10:16:28 natserv01 stringer-web.1.service[2019485]: 127.0.0.1 - - [03/Sep/2020:10:16:28 +0000] "POST /setup/password HTTP/1.0" 500 30 0.0864 ```
|
Happy to merge provided we can get the build passing :) |
|
@Natfan you'll need to also update the |
|
Indeed. Thanks @Natfan for contributing, and sorry this took so long to get to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Personally I was getting 500 erorrs when trying to set up the password, and was getting the following InvalidHash errors. This resolution in an unrelated project that also uses bcrypted resolved this issue for me: heartcombo/devise#4861