-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support stripe.DisputeParams for Close dispute API #566
Support stripe.DisputeParams for Close dispute API #566
Conversation
@brandur @brandur-stripe could u take a look? |
@AlexYaroshenko That change looks good to me! Thanks for making the PR. Brandur: not sure about the build failure on Go 1.10 exactly and why it happens now. Do you think we should merge before my big PR? Happy to rebase on that one again. |
Trivial change that would help me a lot |
@remi-stripe I think the 1.10 failure is just intermittent:
I just restarted it. |
Thanks Alex. LGTM. |
Released as 31.0.0. Heads up Alex: we're about to merge a large breaking change from #544 quite soon which will likely be cut as 32.0.0. We released a separate one here for you so that you can get this fix without having to go straight to that, but if you're just pulling latest, you might need to lock your update to a specific version (31.0.0). |
We are using GLOCK, so i just connected to your 31.0.0 commit ID - should be fine. |
* Don't merge quantities if a quantity doesn't exist due to metered billing * Use metered billing helper in existing tests * Refactored order amendment logic to support metered billing lines These line items do not have quantity in Stripe * Don't rely on stripe_params quantity, maintain own quantity count in phase item struct * Order amendment with metered billing test * Bump structured logger * Logging improvements * Increasing log level * More logging improvements * Stop using serialized_params completely
We should accept and pass forward stripe.DisputeParams that will include
StripeAccount
as for any other calls for Connected AccountsRight now
Close
dispute doesn't work for Connected accountsWorks fine if i am doing manual call with one more header field
Stripe-Account