Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support stripe.DisputeParams for Close dispute API #566

Merged
merged 1 commit into from
Jun 6, 2018

Conversation

AlexYaroshenko
Copy link
Contributor

@AlexYaroshenko AlexYaroshenko commented Jun 6, 2018

We should accept and pass forward stripe.DisputeParams that will include StripeAccount as for any other calls for Connected Accounts
Right now Close dispute doesn't work for Connected accounts

{
    "error": {
        "code": "resource_missing",
        "doc_url": "https://stripe.com/docs/error-codes/resource-missing",
        "message": "No such dispute: dp_***",
        "param": "dispute",
        "type": "invalid_request_error"
    }
}

Works fine if i am doing manual call with one more header field Stripe-Account

@AlexYaroshenko
Copy link
Contributor Author

@brandur @brandur-stripe could u take a look?

@remi-stripe
Copy link
Contributor

@AlexYaroshenko That change looks good to me! Thanks for making the PR.

Brandur: not sure about the build failure on Go 1.10 exactly and why it happens now.

Do you think we should merge before my big PR? Happy to rebase on that one again.

@AlexYaroshenko
Copy link
Contributor Author

Trivial change that would help me a lot

@brandur-stripe
Copy link
Contributor

@remi-stripe I think the 1.10 failure is just intermittent:

go get -u golang.org/x/tools/cmd/cover
package golang.org/x/tools/cmd/cover: unrecognized import path "golang.org/x/tools/cmd/cover" (https fetch: Get https://golang.org/x/tools/cmd/cover?go-get=1: net/http: TLS handshake timeout)

I just restarted it.

@brandur-stripe
Copy link
Contributor

Thanks Alex.

LGTM.

@brandur-stripe brandur-stripe merged commit 09f1fdd into stripe:master Jun 6, 2018
@brandur-stripe
Copy link
Contributor

Released as 31.0.0.

Heads up Alex: we're about to merge a large breaking change from #544 quite soon which will likely be cut as 32.0.0. We released a separate one here for you so that you can get this fix without having to go straight to that, but if you're just pulling latest, you might need to lock your update to a specific version (31.0.0).

@AlexYaroshenko AlexYaroshenko deleted the close_dispute_params branch June 7, 2018 07:34
@AlexYaroshenko
Copy link
Contributor Author

We are using GLOCK, so i just connected to your 31.0.0 commit ID - should be fine.

nadaismail-stripe pushed a commit that referenced this pull request Oct 18, 2024
* Don't merge quantities if a quantity doesn't exist due to metered billing

* Use metered billing helper in existing tests

* Refactored order amendment logic to support metered billing lines

These line items do not have quantity in Stripe

* Don't rely on stripe_params quantity, maintain own quantity count in phase item struct

* Order amendment with metered billing test

* Bump structured logger

* Logging improvements

* Increasing log level

* More logging improvements

* Stop using serialized_params completely
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants