Revert Go module support #774
Conversation
Go module support will be reverted in #774. Here, we update the README with some information about the status of Go modules in stripe-go, and how to use the library with them for the time being.
|
@SamWhited Does everything here look okay to you? It's basically a revert of your patch with a couple additional changes:
Thanks! |
Go module support will be reverted in #774. Here, we update the README with some information about the status of Go modules in stripe-go, and how to use the library with them for the time being.
|
One little nit (see comment inline), but otherwise LGTM. Thanks for all your hard work on this; sorry to waste so much of your time with a patch that ended up having to be reverted. I'll keep the dep issues in mind when pushing for other packages to update in the future. |
Reverts: #712 (And an earlier PR that added a `go.mod` file in the first place.) Unfortunately, there are still some fairly bad incompatibilities between Go modules and Dep for users still on the latter. For now, we're going to revert Go module support because there doesn't seem to be any easy way (i.e., anything that's not maintaining a fork) of doing a good job of both. Projects can still use the Go module system, but will have to pull this package in as a pre-module incompatible one. We are hoping to eventually see basic module awareness merged into Dep: golang/dep#1963 If/when that gets done, we'll revert this revert after a small grace period, and hopefully be back to a place where both packaging systems are well supported. I'll also modify the README to clarify the current situation in another follow up PR.
brandur-stripe
force-pushed
the
brandur-revert-modules
branch
from
66a894a
to
2774ff2
Compare
No worries at all. I don't think the time and effort was wasted because hopefully before too long we'll just be reverting this back and it'll be back in mainline with probably very little changed. Thanks for your hard work on this and the helpful support! |
|
Released as 55.10.0. |
Go module support will be reverted in #774. Here, we update the README with some information about the status of Go modules in stripe-go, and how to use the library with them for the time being.
Go module support will be reverted in #774. Here, we update the README with some information about the status of Go modules in stripe-go, and how to use the library with them for the time being.
Reverts:
#712
(And an earlier PR that added a
go.modfile in the first place.)Unfortunately, there are still some fairly bad incompatibilities between
Go modules and Dep for users still on the latter. For now, we're going
to revert Go module support because there doesn't seem to be any easy
way (i.e., anything that's not maintaining a fork) of doing a good job
of both. Projects can still use the Go module system, but will have to
pull this package in as a pre-module incompatible one.
We are hoping to eventually see basic module awareness merged into Dep:
golang/dep#1963
If/when that gets done, we'll revert this revert after a small grace
period, and hopefully be back to a place where both packaging systems
are well supported.
I'll also modify the README to clarify the current situation in another
follow up PR.
r? @brandur
(WIP.)