Skip to content

Conversation

xavdid-stripe
Copy link
Member

@xavdid-stripe xavdid-stripe commented Sep 5, 2025

Why?

While SDK support for our v1 APIs comes from our public openapi spec, our v2 endpoints have been sources from an internal dump of the protobuf definitions of those APIs.

This PR marks our cutover point for our generation source: now we're using the (private, for now) V2 OpenAPI spec! There are a few changes/bugfixes as a result (documented below).

note: entire PR is codegen

What?

  • generated SDK using v2 openapi spec.

See Also

DEVSDK-2750

Changelog

  • ⚠️ The delete methods for v2 APIs (the ones in the StripeClient.v2 namespace) now return a V2DeletedObject which has the id of the object that has been deleted and a string representing the type of the object that has been deleted.
  • ⚠️ Deeply nested param hashes with no properties no longer have classes generated for them. Instead, they're typed as Dict[str, Any]. Because there were no params, it's unlikely you were using these classes.

@xavdid-stripe xavdid-stripe changed the title Build SDK w/ V2 OpenAPI spec ⚠️ Build SDK w/ V2 OpenAPI spec Sep 5, 2025
@xavdid-stripe xavdid-stripe marked this pull request as ready for review September 5, 2025 21:24
@xavdid-stripe xavdid-stripe requested a review from a team as a code owner September 5, 2025 21:24
@xavdid-stripe xavdid-stripe requested review from mbroshi-stripe and removed request for a team September 5, 2025 21:24
@xavdid-stripe xavdid-stripe merged commit 8d6c7b7 into master Sep 9, 2025
14 checks passed
@xavdid-stripe xavdid-stripe deleted the DEVSDK-2750 branch September 9, 2025 00:23
prathmesh-stripe pushed a commit that referenced this pull request Sep 15, 2025
* generate w/ v2 openapi spec

* gen again

* gen
helenye-stripe pushed a commit that referenced this pull request Sep 22, 2025
* Update generated code for v1868 and 2025-07-30.basil (#1541)

Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com>

* Bump version to 12.4.0

* Introduce V1 namespaces in StripeClient (#1549)

* Introduced V1 namespaces

* Updated migration guide link

* Import available http libraries more efficiently (#1553)

* replace import stragety, fix some tests

[skip ci]

* wip fixing tests

[skip ci]

* [claude] fix tests

* formatting

* test cleanup

* tests are fast

* final cleanup

* remove comment

* remove accidential files

* tweak import logic

* Update generated code for v1932 and 2025-08-27.basil (#1544)

Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com>
Co-authored-by: Ramya Rao <100975018+ramya-stripe@users.noreply.github.com>

* Add section on private preview SDKs in readme (#1554)

* Bump version to 12.5.0

* Add private-preview branch to CI workflow triggers

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* fix: paginate backwards if `starting_after == None` (#1563)

This fixes the case where `starting_after` is present in
`_retrieve_params` but is `None` so that the `auto_paging_iter`
correctly paginates backwards.

closes #1562

* Bump version to 12.5.1

* add support for v2 deleted objects (#1543)

* add support for v2 deleted objects

* revert event destination return type

* ⚠️ Build SDK w/ V2 OpenAPI spec (#1565)

* generate w/ v2 openapi spec

* gen again

* gen

* Updated stripeclient snippets in Readme.md (#1528)

* Don't use mutable default arguments (#1570)

* generate default assignments

* add mutable args linter and fix errors

* type generated args more accurately

* only initialize optional params when needed

* generate private-preview

---------

Co-authored-by: stripe-openapi[bot] <105521251+stripe-openapi[bot]@users.noreply.github.com>
Co-authored-by: Ramya Rao <ramya@stripe.com>
Co-authored-by: prathmesh-stripe <165320323+prathmesh-stripe@users.noreply.github.com>
Co-authored-by: Ramya Rao <100975018+ramya-stripe@users.noreply.github.com>
Co-authored-by: Michael Broshi <mbroshi@stripe.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Ryan Causey <ryan.causey@munipal.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants