Make nested params classes importable #1626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helenye-stripe
requested review from
xavdid-stripe
and removed request for
a team
xavdid-stripe
approved these changes
Oct 2, 2025
helenye-stripe
added a commit
that referenced
this pull request
Oct 2, 2025
* Make nested params classes importable (#1626) * Make nested params classes importable * Add a test export for this * Re-add `tests` to our `sdist` (#1627) * include tests in sdist * include deps too * Make nested params classes importable --------- Co-authored-by: David Brownman <109395161+xavdid-stripe@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
I overlooked the importing of the nested params classes, as pointed out in #1625. Fix to make sure they are importable externally.
What?
Update
__init__.pyfor all stripe params, to include all nested params classes. Add a test to make sure these are importable.See Also
Changelog
stripe.checkout.Session.CreateParamsLineItemandstripe.checkout.Session.CreateParamsDiscount#1625from stripe.params.checkout import SessionCreateParamsDiscountwould raise an error. Now it is valid